flameshot-org/flameshot

Esc undo all my input when I select text tool

Open

#2,499 opened on Mar 22, 2022

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (29,897 stars) (1,916 forks)batch import
EnhancementGood first issue

Description

Flameshot Version

Flameshot v11.0.0 (ad1bf28) Compiled with Qt 5.15.2 darwin: 21.2.0 osx: 12.1

Installation Type

Using the ready-made package from Github Releases

Operating System type and version

MacOS

Description

When I try to add some text in the screenshot, suppose I am tying

"hello", then I type Esc key.

Then all my input would become lost. What my expectations should be "hello" is added into the screenshot and exit the text adding mode.

Is there anyway I could work around this?

Steps to reproduce

  1. Screenshot
  2. Click "add text" tool
  3. Type "hello"
  4. Type Esc key.

Screenshots or screen recordings

No response

System Information

Mac OS 12.1 (21C52)

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic C++Qt event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The bug is that pressing Esc while typing in the text tool clears the input. The fix should preserve the entered text when Esc is used to exit the text tool. Investigate the key press event handling in the text tool widget (likely in src/tools/text/textwidget.cpp or similar). Ensure that Esc triggers exit but does not discard the text. Consider using a modal state or confirming exit if text is present.