flameshot-org/flameshot

Contrasting text outline, shadow or border

Open

#1,249 opened on Jan 21, 2021

View on GitHub
 (21 comments) (12 reactions) (0 assignees)C++ (1,916 forks)batch import
EnhancementGood first issue

Repository metrics

Stars
 (29,897 stars)
PR merge metrics
 (Avg merge 2d 23h) (12 merged PRs in 30d)

Description

It's very important for me for the text to be clearly visible when added to a screenshot. This is usually easily achieved by using black text with white background or white text with black background - but other colours usually look good with either (except maybe for very dark and very light colours). I know that usually the implementations involve:

  • Creating a shadow
  • Creating a border

I do realise I can put a rectangle under text, but it's ugly and obscures a lot more of the image.

As a humorous reference: :smile: white text with black outline can be read on any color

Contributor guide

Research direction
Inspect the current text drawing implementation in the codebase, likely using QPainter. Add text outline or shadow effect by using QPainterPath or QGraphicsDropShadowEffect. Ensure the implementation does not break existing functionality.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Qt
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50