flameshot-org/flameshot

Esc does not close flameshot gui

Open

#1,072 opened on Oct 15, 2020

View on GitHub
 (36 comments) (4 reactions) (0 assignees)C++ (29,897 stars) (1,916 forks)batch import
BugHelp WantedLinux

Description

Flameshot version Flameshot v0.8.5 (AppImage) Compiled with Qt 5.12.8

Describe the bug When any application tries to take over the screen, there will be almost no way to close Flameshot (other than pressing the X button). This happened to me during the following scenarios:

  1. I was in the waiting room of a zoom call and I was taking a screenshot with Flameshot that they let me in the Zoom call and then there was no way to close Flameshot (Esc was not working)
  2. While taking a screenshot I pressed AltTab accidentally and then the Esc was non functional. (This scenario was much easier to repeat)

To Reproduce

  1. flameshot gui
  2. press AltTab (or what ever shortcut you use to switch windows
  3. press Esc to close

Expected behavior Esc works as long as flameshot gui is open.

System Information Distributor ID: Ubuntu Description: Ubuntu 18.04.5 LTS (Ubuntu Budgie) DE: Budgie Release: 18.04 Codename: bionic Display server protocol: X11

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Qtevent handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The bug occurs when the application loses focus via Alt+Tab, causing the Esc key to stop working. Investigate the key press event handling in the main window class, likely in the file src/screenshot/screenshotwidget.cpp or similar. Check how keyboard events are captured and whether focus out events disrupt the event filter. The fix may involve ensuring that the Esc key handler remains active regardless of focus state or re grabbing the keyboard shortcut on focus in events.