Missing `is_symlink` check?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- rust
- Domain
- operating-systems
Research direction
Start with src/lib.rs around lines 90-97 and compare the referenced nushell implementation in crates/nu-completion/src/command.rs around lines 73-86. Determine whether symlink handling is intentional for this utility and check the existing tests for the expected behavior. Done means the behavior is clarified and, if an omission is confirmed, covered by an appropriate test.
Written by the indexing model from the issue text.
Description
This is is_executable of is_executable: https://github.com/fitzgen/is_executable/blob/master/src/lib.rs#L90-L97
This is is_executable of nushell: https://github.com/nushell/nushell/blob/b39dda05500d92b627685b8251bfe416dc621c08/crates/nu-completion/src/command.rs#L73-L86
If you compare them you will notice that nushell has an additional is_symlink() check but is_executable's is_executable does not. Is this intentional or is there potentially an unintended omission?
- Dominant language
- Rust
- Stars
- 24
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fitzgen/is_executable
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
fitzgen/is_executable#12 · 2 comments ·
-
Check ownership too? Open
Difficulty 5/5 Over a week Newbie friendliness 28/100
fitzgen/is_executable#2 · 1 comment ·
All issues in fitzgen/is_executable
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
issue
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
agentic-workflows
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
web-infra-dev/rspack#15847 ·