firtoz/react-three-renderer

Populate all material properties

Open

#48 opened on Mar 11, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,498 stars) (164 forks)batch import
enhancementhelp wanted

Description

  • precision
  • supportsVertexTextures
  • vertexColors
  • flatShading
  • skinning
  • useVertexTexture
  • morphTargets
  • morphNormals
  • doubleSided
  • flipSided
  • shadowMapEnabled
  • pointLightShadows
  • sizeAttenuation
  • logarithmicDepthBuffer
  • alphaTest
  • useFog
  • fog
  • fogExp
  • more?

Should work similar to material.slot attribute:

  • map ( default )
  • envMap ( e.g. slot={'envMap'} )
  • envMap
  • lightMap
  • aoMap
  • emissiveMap
  • bumpMap
  • normalMap
  • displacementMap
  • specularMap
  • roughnessMap
  • metalnessMap
  • alphaMap

See https://github.com/toxicFork/react-three-renderer/issues/34#issuecomment-195487070

Also will need to filter them out of rawShaderMaterial when implemented.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
reactjavascript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Review the current implementation of material components in the react three renderer source, particularly the handling of material.slot attribute. Identify the list of missing properties from the checklist and add them to the appropriate material component files. Also ensure that rawShaderMaterial filters out these properties. Check the linked issue #34 and comment for additional context.