tabFilter no longer filters tabs
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript
Research direction
Start by locating the tab-filtering condition introduced in commit a29df5f and trace how config.tabFilter is applied to process and tab descriptors. Reproduce the issue with include and exclude filters, then verify that tabs are attached only when their URLs satisfy the configured filters.
Written by the indexing model from the issue text.
Description
Setting the tabFilter property in the config or relying on the automatically generated tabFilter per the documentation does not actually result in any filtered tabs. All tabs are attached regardless of filters. This gums up my console log with all console messages from all tabs I have open, rather than just the ones relevant to the app I'm trying to debug, which is quite annoying.
This seems to be a regression introduced in a29df5f. The tabFilter config option is only verified against processes, not tabs:
const url = targetActor.target.url;
if (
descriptorActor.type === 'process' && !targetActor.target.addonId && url &&
(!this.config.tabFilter.include.some(tabFilter => tabFilter.test(url)) ||
this.config.tabFilter.exclude.some(tabFilter => tabFilter.test(url)))
) {
skip = true;
}
This is allowing all tabs through regardless of URL.
- Dominant language
- TypeScript
- Stars
- 447
- Forks
- 76
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from firefox-devtools/vscode-firefox-debug
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
firefox-devtools/vscode-firefox-debug#391 · 2 comments · 1 reaction ·
-
bug path mapping
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Castle Open
Difficulty 5/5 Over a week Newbie friendliness 10/100
-
Create new issue Open
Difficulty 5/5 Over a week Newbie friendliness 1/100
All issues in firefox-devtools/vscode-firefox-debug
Similar issues
-
blocklist removal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
pastelsky/bundlephobia#1122 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100