firefox-devtools/profiler

Add tests for our complex TypeScript typing

Open

#831 opened on Mar 6, 2018

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)TypeScript (486 forks)auto 404
code maintenancehelp wantedready

Repository metrics

Stars
 (1,515 stars)
PR merge metrics
 (PR metrics pending)

Description

We should add some tests to make sure our typing works. My guess is that this broke in the recent Flow upgrade.

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Check if the broken typing is due to the recent Flow upgrade and write tests covering the complex typing scenarios.
Tech stack
typescript
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60