firefox-devtools/profiler

Test coverage for src/components/app

Open

#733 opened on Jan 24, 2018

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)TypeScript (486 forks)auto 404
code maintenancehelp wantedtests

Repository metrics

Stars
 (1,515 stars)
PR merge metrics
 (PR metrics pending)

Description

In trying to find our worst offenders for test coverage, src/components/app/ stands out as being particularly bad. We might need to take on enzyme as a dependency and shallow rendering to properly deal with some of these components.

Files ordered by lines uncovered:

  • Root.js (77 lines uncovered)
  • ProfileSharing.js (67 lines uncovered)
  • ProfileViewer.js (40 lines uncovered)
  • UrlManager.js (32 lines uncovered)
  • Home.js (27 lines uncovered)
  • SymbolicationStatusOverlay.js (23 lines uncovered)
  • TabBar.js (17 lines uncovered)
  • ProfileFilterNavigator.js (9 lines uncovered)
  • FooterLinks.js (3 lines uncovered)
  • Initializing.js (2 lines uncovered)

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Investigate using Enzyme for shallow rendering of the listed components. Start with Root.js (most uncovered) and write unit tests focusing on component behavior and props.
Tech stack
typescriptreact
Domain
frontend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55