firefox-devtools/profiler

ActivityGraph Tooltip should show the sample's page

Open

#3,664 opened on Nov 23, 2021

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)TypeScript (486 forks)auto 404
help wantedtimeline

Repository metrics

Stars
 (1,515 stars)
PR merge metrics
 (PR metrics pending)

Description

I noticed that the tooltip in the activity graph (that's the tooltip with SampleTooltipContents) doesn't show the sample's page url. As a preliminary task, it would be good to extract and merge the code for pages in the existing tooltips: https://github.com/firefox-devtools/profiler/blob/8da8e85846efc90971908ad6fd765f08234018a8/src/components/tooltip/Marker.js#L100-L146 and https://github.com/firefox-devtools/profiler/blob/8da8e85846efc90971908ad6fd765f08234018a8/src/components/tooltip/CallNode.js#L243-L284 They both do interesting but different things.

Afterwards we can use that in https://github.com/firefox-devtools/profiler/blob/8da8e85846efc90971908ad6fd765f08234018a8/src/components/shared/SampleTooltipContents.js#L62, probably right before the Stack.

We could also move SampleTooltipContents from shared to tooltip in the process.

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Extract and merge the page URL code from Marker.js and CallNode.js tooltip components, then integrate it into SampleTooltipContents.js. Consider moving SampleTooltipContents to the tooltip folder.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65