firefox-devtools/profiler

Add a title to context menus

Open

#3,395 opened on Jun 15, 2021

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)TypeScript (486 forks)auto 404
call treehelp wantedmarkerspolish

Repository metrics

Stars
 (1,515 stars)
PR merge metrics
 (PR metrics pending)

Description

It would be good to add a title to the context menus, both in the Call Tree or in the marker chart, so that we know which call node/marker this context menu is about. This would be good for the user to understand the context more.

I'm not sure this is easy to do with the current library we're using. Maybe we'll need to "cheat" by adding a disabled item instead?

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Look at the current context menu implementation, likely using a library like react contextmenu. Explore the documentation or source to see if there is a built in way to add a title, or use a disabled menu item as a workaround.
Tech stack
typescriptreact
Domain
frontenddeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60