firefox-devtools/profiler

The "Profiled Duration:" unit is incorrect

Open

#3,138 opened on Jan 20, 2021

View on GitHubContributor guide
 (10 comments) (0 reactions) (0 assignees)TypeScript (486 forks)auto 404
help wantedpolishprofile data

Repository metrics

Stars
 (1,515 stars)
PR merge metrics
 (PR metrics pending)

Description

In the metadata panel, at the bottom of the "Profiler Overhead" section, I see "Profiled Duration" displayed with a micro second unit, but I suspect the value is in ms. The "Overhead Percentage" shown is above 6000%, which doesn't make sense, it's likely 6%.

Example profile: https://share.firefox.dev/39HHwhu

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Look at the code in the profiler that formats and displays the 'Profiled Duration' value. The unit should be milliseconds (ms) but is incorrectly shown as microseconds (µs). Find where the unit is defined and fix it to display 'ms' instead of 'µs'.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70