firefox-devtools/profiler

Clean up the fallback label code for FileIO markers

Open

#3,131 opened on Jan 15, 2021

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)TypeScript (486 forks)auto 404
code maintenancehelp wantedmarkersneeds gecko patch

Repository metrics

Stars
 (1,515 stars)
PR merge metrics
 (PR metrics pending)

Description

In the following code, we have some fallback code dedicated to FileIO markers: https://github.com/firefox-devtools/profiler/blob/c87e4e9127aa1f2e423dd81712cc4f829cf24e6f/src/profile-logic/marker-schema.js#L279-L289

This doesn't seem necessary nowadays as this could be implemented as a schema. The work here is:

  1. implement in gecko the schema that does this. (or check that it's implemented)
  2. remove the aforementioned fallback code
  3. add migration steps to both gecko and processed profile versioning to add the data to marker schemas from older profiles.
  4. possibly add tests if there's some missing for this case

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Inspect the fallback code in marker schema.js (lines 279-289) and verify if gecko provides the needed schema. Then remove the fallback code and update migration steps for both gecko and processed profiles. Consider adding tests.
Tech stack
typescript
Domain
performance
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50