firefox-devtools/profiler

C++-demangle JS function names for emscripten'd code

Open

#167 opened on Feb 27, 2017

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)TypeScript (486 forks)auto 404
help wanted

Repository metrics

Stars
 (1,515 stars)
PR merge metrics
 (PR metrics pending)

Description

If you compile a C++ project to JS using emscripten, you end up with JS function names like __ZN20ShaderConstantBuffer9SetFloat3EiRKN4math6float3E. Profiles of such code can be hard to read. We should run function names through a demangler so that they become readable; in the example that would be ShaderConstantBuffer::SetFloat3(int, math::float3 const&).

There's a demangle module on npm that can do this.

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Investigate where JS function names are displayed in the profiler, add the 'demangle' npm package, and demangle function names that match the C++ mangling pattern (e.g., starting with ' Z') before displaying them.
Tech stack
javascripttypescriptcpp
Domain
devtoolsperformance
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60