`CompressibleHybridisedSCPC` needs a `view` method.

Open Beginner friendly
#704 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
hpc

Research direction

Find the CompressibleHybridisedSCPC class and compare its interface with firedrake.PCDPC.view in the linked example. Start by tracing the sub-solvers created by this preconditioner, then implement recursive viewing for each one, including self.hybridised_solver.snes.view(viewer). Done means -ksp_view on the outer solver reports the inner solvers too.

Written by the indexing model from the issue text.

Description

This method is needed so that passing -ksp_view to the outer solver propagates down to the inner solvers set up by this PC.
The view method would need to recursively call view on all sub solvers (e.g. self.hybridised_solver.snes.view(viewer)).

An example of this can be seen in firedrake.PCDPC.view:
https://github.com/firedrakeproject/firedrake/blob/0f6aa1175c119d265f58f51325880a16ee22f9ce/firedrake/preconditioners/pcd.py#L136-L144

Dominant language
Python
Stars
20
Forks
13
Avg merge
2d 15h
Merged PRs (30d)
3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from firedrakeproject/gusto

All issues in firedrakeproject/gusto

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.