config/index.js does not exit after executing
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- cli
Research direction
Start with config/index.js and reproduce the issue using node config/index.js get. Trace the getTemplate flow and confirm that the command terminates after both successful and failed execution; done means the command exits instead of remaining open.
Written by the indexing model from the issue text.
Description
When I run "node config/index.js get", it was actually executed successfully, but it does not exit.
Shall we need to add "finally" block like the following?
function getTemplate() {
const config = admin.remoteConfig();
config.getTemplate()
.then(template => {
console.log('ETag from server: ' + template.etag);
const templateStr = JSON.stringify(template, null, 2);
fs.writeFileSync('config.json', templateStr);
})
.catch(err => {
console.error('Unable to get template');
console.error(err);
}).finally(() => {
process.exit();
});
}
- Dominant language
- JavaScript
- Stars
- 933
- Forks
- 426
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from firebase/quickstart-nodejs
-
Ok Open
Difficulty 5/5 Over a week Newbie friendliness 5/100
firebase/quickstart-nodejs#305 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
firebase/quickstart-nodejs#253 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
firebase/quickstart-nodejs#194 · 3 comments · 8 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 24/100
firebase/quickstart-nodejs#106 · 6 comments · 3 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 20/100
firebase/quickstart-nodejs#97 · 1 comment ·
All issues in firebase/quickstart-nodejs
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·