Sample still using Deprecated Firebase AdMob firebase::admob
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- mobile-dev
Research direction
Start by locating the AdMob sample files and the firebase::admob references shown in common_main.cc, then check the current Google Mobile Ads C++ SDK API. The work is done when the affected samples no longer use the deprecated namespace and build successfully for the reported Android target.
Written by the indexing model from the issue text.
Description
[REQUIRED] Please fill in the following fields:
- Which Firebase Sample: Admob(Auth, Database, etc.)
- Firebase C++ SDK version: firebase_cpp_sdk_11.6.0
- Additional SDKs you are using: Admob (Facebook, AdMob, etc.)
- Platform you are using the SDK on: Windows (Mac, Windows, or Linux)
- Platform you are targeting: Android(iOS, Android, and/or desktop)
[REQUIRED] Please describe the issue here:
The sample files seem to be out of date, they have not been update to include the change from
recated Firebase AdMob C++ SDK"firebase::admob" to New Google Mobile Ads C++ SDK
(Please list the full steps to reproduce the issue. Include device logs, and stack traces if available.)
Steps to reproduce:
What's the issue repro rate? (eg 100%, 1/5 etc)
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Download and following information in sample to setup and run a sample code
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
// A simple listener that logs changes to a BannerView.
class LoggingBannerViewListener : public firebase::admob::BannerView::Listener {
public:
LoggingBannerViewListener() {}
void OnPresentationStateChanged(
firebase::admob::BannerView* banner_view,
firebase::admob::BannerView::PresentationState state) override {
::LogMessage("BannerView PresentationState has changed to %d.", state);
}
void OnBoundingBoxChanged(firebase::admob::BannerView* banner_view,
firebase::admob::BoundingBox box) override {
::LogMessage(
"BannerView BoundingBox has changed to (x: %d, y: %d, width: %d, "
"height %d).",
box.x, box.y, box.width, box.height);
}
};`// A simple listener that logs changes to a BannerView.
class LoggingBannerViewListener : public firebase::admob::BannerView::Listener {
public:
LoggingBannerViewListener() {}
void OnPresentationStateChanged(
firebase::admob::BannerView* banner_view,
firebase::admob::BannerView::PresentationState state) override {
::LogMessage("BannerView PresentationState has changed to %d.", state);
}
void OnBoundingBoxChanged(firebase::admob::BannerView* banner_view,
firebase::admob::BoundingBox box) override {
::LogMessage(
"BannerView BoundingBox has changed to (x: %d, y: %d, width: %d, "
"height %d).",
box.x, box.y, box.width, box.height);
}
};
E:/code2023/123456/testapp/src/common_main.cc:26:52: error: no member named 'admob' in namespace 'firebase'
class LoggingBannerViewListener : public firebase::admob::BannerView::Listener {`
- Dominant language
- C++
- Stars
- 260
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from firebase/quickstart-cpp
-
Mireb commercial Opennew
Difficulty 5/5 Over a week Newbie friendliness 1/100
firebase/quickstart-cpp#151 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
firebase/quickstart-cpp#128 · 2 comments ·
-
new
Difficulty 5/5 Over a week Newbie friendliness 15/100
firebase/quickstart-cpp#126 · 1 comment ·
-
type: feature request
Difficulty 4/5 3-5 days Newbie friendliness 35/100
firebase/quickstart-cpp#23 · 3 comments · 1 reaction ·
All issues in firebase/quickstart-cpp
Similar issues
-
AuTest Bug Tests
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/trafficserver#13714 ·
-
bug build
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
facebookincubator/velox#19143 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
tenstorrent/tt-metal#57393 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
objectionary/eo-graphs#74 ·