Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Usability in testing scenarios - unhandled promise rejections

Open
#54 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
firebase, javascript, react
Domain
frontend, testing

Research direction

No file or test is named in the issue. Start by locating the two promises in the React wrapper and reproduce the failure with the .env variables missing; done means the test environment has no unhandled promise rejections while the OAuth behavior remains intact.

Written by the indexing model from the issue text.

Description

Hey @nicolasgarnier !

I've been using your component for a hot minute, implementing OAuth in an app I'm contributing to.

There are 2 unhandled promise rejections in this plugin that will automatically fail in a test environment where .env variables are missing.

Is there a special way this plugin should be tested?
If not would it be feasible to implement a catch for each of the 2 used promises in order for it not to have to be mocked out completely?

I tested it in a fork locally and it works like a charm for me, if I should open a PR for this, please let me know!

Dominant language
JavaScript
Stars
1.3k
Forks
246
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from firebase/firebaseui-web-react

All issues in firebase/firebaseui-web-react

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.