Failed to parse json credential

Open
#814 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
firebase, python

Research direction

Start in firebase_admin/credentials.py at _is_file_path and inspect how Certificate handles a parsed JSON dictionary versus a credential file path. Reproduce the reported OSError with the issue's environment details, then verify that dictionary credentials are recognized correctly without breaking path handling.

Written by the indexing model from the issue text.

Description

api: auth
[READ] Step 1: Are you in the right place?
  • For issues related to the code in this repository file a GitHub issue.
  • If the issue pertains to Cloud Firestore, report directly in the
    Python Firestore GitHub repo. Firestore
    bugs reported in this repo will be closed with a reference to the Python Firestore
    project.
  • For general technical questions, post a question on StackOverflow
    with the firebase tag.
  • For general Firebase discussion, use the firebase-talk
    google group.
  • For help troubleshooting your application that does not fall under one
    of the above categories, reach out to the personalized
    Firebase support channel.
[REQUIRED] Step 2: Describe your environment
  • Operating System version: MacOS Sonoma 14.3.1
  • Firebase SDK version: 6.5.0
  • Firebase Product: auth
  • Python version: 3.11.0
  • Pip version: 24.0
[REQUIRED] Step 3: Describe the problem

When calling firebase_admin.credentials.Certificate, occurred error OSError, which used not credential file path, but parsed json dictionary. I expect returning function _is_file_path False if used parameter as dictionary.

Steps to reproduce:

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

Relevant Code:
# firebase_admin/credentials.py
def _is_file_path(path):
    try:
        path_obj = pathlib.Path(path)
        return True
    except TypeError:
        return False
Dominant language
Python
Stars
1.2k
Forks
359
Avg merge
5d 6m
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from firebase/firebase-admin-python

All issues in firebase/firebase-admin-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.