[FR] Add test for "must not exceed the maximum of 4 weeks"

Open
#2,832 1 comment 0 reactions 1 assignee View on GitHub

@chong-shao is already working on this.

Since Feb 18, 2025.

Assessment

This issue has not been assessed yet.

Description

api: messaging type: feature request

Is your feature request related to a problem? Please describe.
When inserting a pushnotification, its TTL may not exceed 4 weeks according to docs.
This is only checked after the request is send to the API. It should be checked in the library, to easier catch bugs and not annoy the API.

Describe the solution you'd like
Check the payload TTL locally (in the library) for common mistakes.

Describe alternatives you've considered
Right now its done to the enduser of checking this. And the results may vary. In the end it can happend due to bugs or other things that invalid payloads still get send to the API - when this library could've prevented that.

Thanks for consideration.

Dominant language
TypeScript
Stars
1.7k
Forks
419
Avg merge
3d 10h
Merged PRs (30d)
16

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from firebase/firebase-admin-node

All issues in firebase/firebase-admin-node

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.