[FR] adding toJSON property to the Admin SDK Timestamp class
@lahirumaramba is already working on this.
Since Dec 20, 2023.
Assessment
This issue has not been assessed yet.
Description
Is your feature request related to a problem? Please describe.
Working in monorepos or other situations with shared Typescript interfaces is complicated because toJSON property is missing on the Admin SDK Timestamp definition
Can firebase-admin package and firebase package share same type definition of some common class?
For example firebase-admin Timestamp class is defined here but firebase Timestamp class is defined here and they are different.
Describe the solution you'd like
adding toJSON property to the Admin SDK Timestamp class to make it compatible to firebase Timestamp class.
Describe alternatives you've considered
Split the common class type definition to a separate package?
Additional context
Discussed at #1404 before, but no contributor response after hiranya911 is not active in firebase project.
- Dominant language
- TypeScript
- Stars
- 1.7k
- Forks
- 419
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 16
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from firebase/firebase-admin-node
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
firebase/firebase-admin-node#3234 ·
-
firebase/firebase-admin-node#3221 · 3 comments · 1 assignee ·
-
api: messaging
Difficulty 3/5 1-2 days Newbie friendliness 70/100
firebase/firebase-admin-node#3215 ·
-
api: messaging
Difficulty 5/5 Over a week Newbie friendliness 28/100
firebase/firebase-admin-node#3214 ·
-
api: firestore type: feature request
firebase/firebase-admin-node#3183 · 1 comment · 1 assignee ·
All issues in firebase/firebase-admin-node
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
bcgov/bc-wallet-mobile#4761 · 1 comment ·
-
external-issue to-triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
area-deployment area-integrations triage:bot-seen
Difficulty 2/5 Half a day Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
refactor
Difficulty 2/5 1-3 hours Newbie friendliness 84/100