finos/morphir-elm

Remove Field from value expressions in the IR and use FieldFunction with Apply as a replacement

Open

#156 opened on Sep 17, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Elm (69 forks)auto 404
enhancementgood first issueir-simplification

Repository metrics

Stars
 (51 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently the IR has both Field and FieldFunction as values in the IR. The corresponding example in Elm would be a.foo vs. .foo. The idea is that a.foo can be represented as .foo a (applying the .foo function to a). The latter is more generic and the former is basically just a special combination of FieldFunction and Apply therefore it's accidental complexity which should be removed.

The specific change is to remove Field: https://github.com/finos/morphir-elm/blob/5e18e70bd4631aea1d1b677be04b62de3069a5eb/src/Morphir/IR/Value.elm#L90

And replace throughout the codebase using the following substitution rule:

Field a subjectValue fieldName -> Apply a (FieldFunction a fieldName) subjectValue

Contributor guide

Research direction
Identify all occurrences of `Field` in the codebase, understand the substitution rule, and replace each with `Apply (FieldFunction a fieldName) subjectValue`. Ensure that the IR and all related transformations are updated consistently.
Tech stack
None
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElmGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30