fin-hypergrid/core

No way of temporarily displaying a grid and removing it, as clean up isn't implemented

Open

#629 opened on Sep 16, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (892 stars) (148 forks)batch import
bughelp wanted

Description

Hi,

Thanks for a great library! :-) I've created some proof-of-concepts at work using the older version.

Right now I'm looking to open a "widget" (terrible name I know) that contains a grid. The user can close the widget. Therefore, it needs to have its resources cleaned up.

grid.stopPaintThread() and grid.stopResizeThread() are not hooked up correctly and throw.

I can call grid.canvas.stopPaintLoop() successfully to stop hooking into requestAnimationFrame instead.

However, there is currently no way to remove the document level events that the canvas hooks up. This causes exceptions to be thrown once the element containing the div is removed from the page.

See: https://github.com/fin-hypergrid/core/blob/master/src/lib/Canvas.js#L53

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptevent listeners
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests cleanup logic for document level events in Canvas.js. The existing stopPaintLoop works but removal of event listeners is missing. Look at Canvas.js around line 53 to understand how events are bound. Implement a method to unbind them, ensuring the grid can be safely removed from the DOM. Check if there are any existing teardown methods or if stopResizeThread and stopPaintThread should be fixed.