fin-hypergrid/core

Possible bug with getSelectedRows?

Open

#508 opened on Feb 7, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (148 forks)batch import
bughelp wanted

Repository metrics

Stars
 (892 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I believe there is a bug with the select all functionality. In my table, I have a header row, a top totals row and 14 rows in my data grid. However, grid.getSelectedRows() returns array(2, ...,13) thus missing rows 14 and 15. This is related to var rowCount = this.grid.getRowCount() - headerRows; which returns 0 while there is still 2 elements in the data array of the datasource in lib/SelectionModels.js at getSelectedRows. Because of the header and summary row, it always leave two rows on the table. I can delete the two remaining rows individually though i.e. when this.areAllRowsSelected() is false.

Contributor guide

Research direction
Investigate the getSelectedRows method in lib/SelectionModels.js to understand how headerRows are subtracted from rowCount, and verify if the data array indexing is off by two due to header and summary rows.
Tech stack
javascript
Domain
frontendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70