fin-hypergrid/core

Possible bug with getSelectedRows?

Open

#508 opened on Feb 7, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (892 stars) (148 forks)batch import
bughelp wanted

Description

I believe there is a bug with the select all functionality. In my table, I have a header row, a top totals row and 14 rows in my data grid. However, grid.getSelectedRows() returns array(2, ...,13) thus missing rows 14 and 15. This is related to var rowCount = this.grid.getRowCount() - headerRows; which returns 0 while there is still 2 elements in the data array of the datasource in lib/SelectionModels.js at getSelectedRows. Because of the header and summary row, it always leave two rows on the table. I can delete the two remaining rows individually though i.e. when this.areAllRowsSelected() is false.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptBasic understanding of grid row counting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the getSelectedRows method in lib/SelectionModels.js. The bug occurs because rowCount is computed as grid.getRowCount() headerRows, but headerRows counts header and summary rows, causing omission of data rows. Investigate how headerRows is defined and consider using a row count that excludes header and summary rows. The user suggests that when areAllRowsSelected() is false, individual deletion works, suggesting a fix in the selection logic.