files-community/Files

Bug: The add tab button shifts when a non-tab item is dragged next to it

Closed

#14,143 opened on Dec 3, 2023

View on GitHubContributor guide
 (13 comments) (0 reactions) (0 assignees)C# (2,719 forks)batch import
area - tabsgood first issue

Repository metrics

Stars
 (43,502 stars)
PR merge metrics
 (Avg merge 11d 15h) (61 merged PRs in 30d)

Description

Description

related to feature #4710 which I will be PRing shortly I will take on this bug fix in the next couple days

Steps To Reproduce

  1. Drag anything between the + button and the rightmost tab
  2. The button skips to the right even if a non tab item is dragged next to it

Requirements

Button should only skip when dragging a tab

Files Version

3.0.13.0

Windows Version

Windows 11 22H2

Log File

debug.log

Contributor guide

Research direction
Examine the drag and drop handler for the tab bar, likely in a file related to tab control or drag behavior. The bug is that the add button shifts when any item (not just tabs) is dragged next to it. The fix should condition the button's repositioning on the dragged item being a tab. Review the code for event handlers that trigger on drag over the button area, and check the type of the dragged item. Also look at related issue #4710 for context on the recent feature that introduced this behavior.
Tech stack
csharp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C# fundamentalsXAML basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70