filamentphp/filament

Grid table border on hover/select in dark mode

Open

#7784 opened on Aug 15, 2023

View on GitHub
 (1 comment) (0 reactions) (1 assignee)PHP (30,736 stars) (4,162 forks)batch import
bughelp wantedlow priorityneeds more infoui

Description

Package

filament/tables

Package Version

v3.0.19

Laravel Version

v10.18.0

Livewire Version

v3.0.0-beta.7

PHP Version

PHP 8.2

Problem description

Just a follow up. PR #7636 introduced a slight difference between classic tables and grid tables hover/select appearance in dark mode.

before

after

Expected behavior

Both "tables" should look the same.

Steps to reproduce

  • Install Filament v3.0.18
  • Create a table with and without Grid Layout (e.g. Stack/Split columns)
  • Upgrade to Filament v3.0.19 (which includes the mentioned PR).

Reproduction repository

https://github.com/ajnsn/filament-demo-borders

Relevant log output

No response

Contributor guide

Tech stack
csstailwindcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSTailwind CSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the changes introduced in PR #7636 regarding grid table hover/select styles in dark mode. Compare the CSS classes applied to grid tables and classic tables. The issue likely lies in the filament tables package's CSS, specifically in files related to table row hover states. Ensure that grid tables also receive the appropriate border highlight on hover/select in dark mode, similar to classic tables.