filamentphp/filament

MDE behaves differently when submitted via mouse click vs keyBinding

Closed

#12,858 opened on May 19, 2024

View on GitHub
 (8 comments) (0 reactions) (0 assignees)PHP (4,162 forks)batch import
bughelp wantedlow priorityunconfirmed

Repository metrics

Stars
 (30,736 stars)
PR merge metrics
 (Avg merge 3d 15h) (55 merged PRs in 30d)

Description

Package

filament/forms

Package Version

3.2.80

Laravel Version

11.7.0

Livewire Version

3.4.12

PHP Version

8.2.18

Problem description

The behavior of clicking on submit vs pressing the registered keyBinding() is different. Clicking will clear the form. (correct) Pressing the shortcut key does not. (incorrect)

Expected behavior

Pressing the shortcut key should also clear the form.

Steps to reproduce

  1. Type something into the markdown editor at /admin/issue
  2. Press ctrl + enter

Reproduction repository

https://github.com/bilogic/filament-issue/tree/click-different-from-keyBindings

Relevant log output

https://github.com/filamentphp/filament/assets/946010/fb144bf9-802f-4003-8dcd-ec4c2148e742

No response

Contributor guide

Research direction
Compare the event handlers for the keybinding and mouse click submission in the MarkdownEditor component. Inspect how the form is cleared in the click handler but not in the keybinding handler, and ensure both trigger the same clear logic.
Tech stack
phpjavascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPLaravelLivewire
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70