filamentphp/filament

MDE behaves differently when submitted via mouse click vs keyBinding

Open

#12858 opened on May 19, 2024

View on GitHub
 (8 comments) (0 reactions) (0 assignees)PHP (30,736 stars) (4,162 forks)batch import
bughelp wantedlow priorityunconfirmed

Description

Package

filament/forms

Package Version

3.2.80

Laravel Version

11.7.0

Livewire Version

3.4.12

PHP Version

8.2.18

Problem description

The behavior of clicking on submit vs pressing the registered keyBinding() is different. Clicking will clear the form. (correct) Pressing the shortcut key does not. (incorrect)

Expected behavior

Pressing the shortcut key should also clear the form.

Steps to reproduce

  1. Type something into the markdown editor at /admin/issue
  2. Press ctrl + enter

Reproduction repository

https://github.com/bilogic/filament-issue/tree/click-different-from-keyBindings

Relevant log output

https://github.com/filamentphp/filament/assets/946010/fb144bf9-802f-4003-8dcd-ec4c2148e742

No response

Contributor guide

Tech stack
phplaraveljavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Filament formsLivewire event handlingJavaScript key bindings
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Focus on the MarkdownEditor component within the filament/forms package. The issue describes a discrepancy between mouse click and key binding submission paths. Examine the JavaScript event handlers (likely in resources/js/components/markdown editor.js or similar) to identify why the key binding does not trigger the form clearing logic. Check the provided reproduction repository (https://github.com/bilogic/filament issue/tree/click different from keyBindings) for environment setup and test the behavior. Review the 8 comments in the issue for any maintainer suggestions or additional context.