fs.rmdir deprecated

Open Beginner friendly
#38 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
javascript, node.js
Domain
backend

Research direction

Open index.js around line 49 and inspect the doZip path shown in the warning. Replace the deprecated recursive removal usage with the supported equivalent, then run the package tests or a zip-creation example and confirm the deprecation warning no longer appears.

Written by the indexing model from the issue text.

Description

I got this warning from your package. It looks easy to fix. Just to let you know:

(node:18676) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
    at emitRecursiveRmdirWarning (node:internal/fs/utils:869:13)
    at Object.rmdir (node:fs:1164:5)
    at doZip (C:\...\node_modules\cross-zip\index.js:49:10)
    at C:\...\node_modules\cross-zip\index.js:22:9
    at FSReqCallback.oncomplete (node:fs:198:5)
Dominant language
JavaScript
Stars
129
Forks
24
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from feross/cross-zip

All issues in feross/cross-zip

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.