zero fill to make abstract-chunk-store compliant

Open Beginner friendly
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, node.js
Domain
backend, testing

Research direction

Start in write.js at the zeroPadding option referenced by the issue, then read abstract-chunk-store tests/index.js lines 25-34 to confirm the expected behavior for short chunks. Run the relevant test suite and consider the work complete when chunks smaller than chunkLength produce the expected error.

Written by the indexing model from the issue text.

Description

I think zeroPadding: false violates the expectations of the abstract-chunk-store test suite: https://github.com/mafintosh/abstract-chunk-store/blob/master/tests/index.js#L25-L34

With zeroPadding: false, chunks are written to the store that are smaller than the chunkLength, which according to the abstract-chunk-store tests should result in an error.

Dominant language
JavaScript
Stars
26
Forks
6
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.