feross/buffer

Support 'buffer' encoding

Open

#227 opened on Feb 19, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (259 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Since Node.js v10.0.0 crypto.DEFAULT_ENCODING is deprecated and the default value is now 'buffer', which makes methods default to Buffer objects. I am running into an issue where Buffer.from is called on a string, but the encoding is buffer. That throws an exception because Buffer.isEncoding doesn't support the buffer encoding.

I'd suggest to add this to allow users to integrate this with a more up-to-date version of node.

Would it already work if we just adjust Buffer.isEncoding and add buffer as one of the supported types? Or do we need to do more to make this work?

Contributor guide

Research direction
Check the source code to see where Buffer.isEncoding is defined and add 'buffer' to the list of supported encodings.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80