fengyuanchen/cropperjs

Memory not released in Safari when editing multiple images

Open

#963 opened on Jul 20, 2022

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (12,111 stars) (2,388 forks)batch import
help wantedquestionv1

Description

When multiple images are uploaded, page memory is adding up and never released. Especially when using mobile devices, this results in the WebView to eventually reload (this is especially problematic when Cropper.js is implemented in a page with other information, as that information would then be lost).

To Reproduce: While monitoring memory usage in Safari's Web Inspector 1 - Upload image 2 - Upload another image ..n - Upload another image

Screenshots cropperJS 2 cropperJS

Tested on:

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptMemory leak debuggingSafari Web Inspector
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the memory management in cropperjs, particularly during image loading and canvas operations. Focus on Safari's memory handling. Review the image cropping loop to see if objects are properly dereferenced. Consider using Safari's Timeline to track allocations.