When the 189 patch trailer is not in the spec, don't add it

Open
#16 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start by tracing how importpatches handles patch 189 and reconstructs the spec, comparing the spec before and after the tool runs. Done means the setuptools/pip version blurb is not added when patch 189 is unchanged and the blurb was previously absent, while it remains correct in other cases.

Written by the indexing model from the issue text.

Description

In here, https://src.fedoraproject.org/rpms/python3.6/c/ca58751035496b75ebc1a5dd46ebdbecca825a14?branch=rawhide @frenzymadness removed:

-# The following versions of setuptools/pip are bundled when this patch is not applied.
-# The versions are written in Lib/ensurepip/__init__.py, this patch removes them.
-# When the bundled setuptools/pip wheel is updated, the patch no longer applies cleanly.
-# In such cases, the patch needs to be amended and the versions updated here:
-%global pip_version 18.1
-%global setuptools_version 40.6.2

At that time, I have not considered the removal a problem. It made sense.

However, now @stratakis adds a new patch to python3.6 and improtpatches add this blurb back.

Maybe importpatches could skip adding this blurb when:

  • patch 189 is unchanged
  • the blurb was not there before improtpatches run

WDYT?

Dominant language
Python
Stars
4
Forks
4
Avg merge
3d 18h
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fedora-python/importpatches

All issues in fedora-python/importpatches

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.