feathr-ai/feathr

[BUG] useLatestFeatureData doesn't use the latest feature data, but use "today's" feature data (which might not exist)

Open

#898 opened on Dec 2, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Scala (1,929 stars) (244 forks)batch import
buggood first issue

Description

Willingness to contribute

No. I cannot contribute a bug fix at this time.

Feathr version

0.9.0

System information

NA

Describe the problem

When using joinTimeSettings: { useLatestFeatureData: true }, Feathr uses LocalDateTime.now() to get the join time range. This results in None features if the feature's date is not "today".

Expected behavior is to use the max timestamp value from the feature data source so that it actually joins the "latest" feature data available.

Tracking information

No response

Code to reproduce bug

No response

What component(s) does this bug affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React

Contributor guide

Tech stack
scala
Domain
backenddata
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Scala basicsSpark conceptsFeathr join semantics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The bug is in the computation engine (Scala/Spark). The issue states that `useLatestFeatureData: true` causes `LocalDateTime.now()` to be used instead of the max timestamp from the feature data. Look for the join logic that handles `useLatestFeatureData` in the Scala source code, likely in the feature join or observation generation components. Search for `useLatestFeatureData` in the repository to locate relevant files. The fix would involve replacing the current date call with a query to get the maximum timestamp from the feature source.
[BUG] useLatestFeatureData doesn't use the latest feature data, but use "today's" feature data (which might not exist) · feathr-ai/feathr#898 | Good First Issue