feathr-ai/feathr

Path concatenation without forward slash

Open

#297 opened on May 23, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Scala (1,929 stars) (244 forks)batch import
featuregood first issue

Description

This is reported by Manjunath from Slack channel. For work_dir: "dbfs:/feathr_getting_started" The user was running jupyter notebook from windows. without forward slash('dbfs:/feathr_getting_started') the job configs were coming as '--join-config', 'dbfs:/feathr_getting_started\feature_join.conf'

To fix this, the user need to add foward slash: work_dir: "dbfs:/feathr_getting_started"

We should add validation or automatically append a forward slash. The best way would be using Path utils that can join files/folders properly.

Contributor guide

Tech stack
scalapythonspark
Domain
data
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is about path concatenation errors when work dir lacks a trailing slash. The fix should involve adding validation or using path joining utilities (e.g., os.path.join in Python, Path in Scala) to ensure proper joining. Look at the configuration handling code, possibly in the Python SDK or Scala job submission components. Test on Windows to confirm the fix.
Path concatenation without forward slash · feathr-ai/feathr#297 | Good First Issue