feast-dev/feast

Update great-expectations to latest (>1)

Open

#5,087 opened on Feb 25, 2025

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Python (5,029 stars) (896 forks)batch import
good first issuekind/bugpriority/p2

Description

Expected Behavior

great-expectations version updated to latest (>1).

https://github.com/feast-dev/feast/blob/master/pyproject.toml#L73

Current Behavior

The great_expectations.dataset module, which included classes like PandasDataset, has been deprecated in recent versions of Great Expectations and was fully removed in version 1.0. This change means that attempting to import from great_expectations.dataset will result in a ModuleNotFoundError

https://github.com/feast-dev/feast/blob/master/sdk/python/tests/integration/offline_store/test_dqm_validation.py#L8

Steps to reproduce

Update great-expectations to latest and run sdk/python/tests/integration/offline_store/test_dqm_validation.py

Contributor guide

Tech stack
pythonpandas
Domain
datamachine learning
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonDependency management in PythonBasic testing concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
First, examine the current great expectations version in pyproject.toml and update it to the latest version. Then, review test dqm validation.py to replace deprecated imports from great expectations.dataset with the new API, as per Great Expectations documentation. Also search the codebase for any other usages of the deprecated module. Finally, run the test suite to ensure all tests pass.