fbchat-dev/fbchat

Sending a GIF from gfycat result in attachment to download

Open

#461 opened on Aug 10, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (406 forks)github user discovery
bugenhancementhelp wanted

Repository metrics

Stars
 (1,210 stars)
PR merge metrics
 (PR metrics pending)

Description

Description of the problem

I'm trying to send a Gif from gfycat to a Group, it results in an attachement in the thread instead of a preview of it...

Code to reproduce

def send_image(image_path): client = Client(login, password) client.sendRemoteFiles([image_path], thread_id=thread_id, thread_type=ThreadType.GROUP)

Note that the same thing happen with sendLocalFiles (by appending .gif or not in the filename)

Environment information

  • Python version : 3.7.4
  • fbchat version : 1.7.3

If you have done any research, include that. Make sure to redact all personal information.

Contributor guide

Research direction
Investigate how the library handles sending remote files, specifically GIF URLs. Trace the code path from sendRemoteFiles to the underlying HTTP requests and see why the GIF is being sent as an attachment instead of a preview. Look for any missing MIME type detection or special handling for GIFs.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75