Cannot pass Time parameter to time_entries.updated_since

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
api

Research direction

Start in time_entries.rb and reproduce the failure with a Time, DateTime, or ISO 8601 string passed as updated_since. Trace the .map call and compare the generated request with the working Date case; done means supported time values no longer raise NoMethodError and the API receives the intended updated_since value.

Written by the indexing model from the issue text.

Description

bug

This works:

h = Harvesting::Client.new
h.time_entries(updated_since: Date.yesterday)

This does not work:

h = Harvesting::Client.new
h.time_entries(updated_since: 1.hour.ago)

All attempts to pass time in addition to a date yield the following error:
NoMethodError (undefined method `map' for nil:NilClass)

I have tried with Time and DateTime classes, as well as passing a string (e.g. Time.now.iso8601) - all return this error, even though the Harvest API says time is acceptable in this field. I looked through time_entries.rb and see where this gem is trying to do a .map but got lost from there on where this is failing. Thanks in advance.

Dominant language
Ruby
Stars
29
Forks
30
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fastruby/harvesting

All issues in fastruby/harvesting

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.