e2mmap benchmark is not working (missing gem) in Ruby 3.0.x

Open
#196 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
20/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
ruby
Domain
performance

Research direction

Start with code/general/raise-vs-e2mmap.rb and review the related discussion in issue #95. Check whether the benchmark is intended to remain, then remove that scenario as proposed or confirm the Gemfile change is appropriate. Done means the benchmark no longer fails because e2mmap is missing.

Written by the indexing model from the issue text.

Description

Hi there,

At the moment this benchmark is not working:

➜  fast-ruby git:(master) ✗ ruby -v code/general/raise-vs-e2mmap.rb
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-darwin20]
<internal:/Users/etagwerker/.rvm/rubies/ruby-3.0.2/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- e2mmap (LoadError)
	from <internal:/Users/etagwerker/.rvm/rubies/ruby-3.0.2/lib/ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from code/general/raise-vs-e2mmap.rb:2:in `<main>'

The solution would be to add this to the Gemfile:

gem 'e2mmap'

It seems that that benchmark might not be wanted in this project. After all, it is comparing Ruby vs. using the e2mmap gem. See: https://github.com/JuanitoFatas/fast-ruby/issues/95

I'm going to submit a PR removing that scenario, which should fix this issue. 😄

Dominant language
Ruby
Stars
5.7k
Forks
370
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fastruby/fast-ruby

All issues in fastruby/fast-ruby

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.