fastify/fastify-cli

watch mode not working with git worktree

Open

#548 opened on Sep 7, 2022

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)JavaScript (174 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (726 stars)
PR merge metrics
 (Avg merge 54m) (3 merged PRs in 30d)

Description

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.0.0

Plugin version

No response

Node.js version

16.17.0

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

20.04

Description

At #547, I mistakenly assumed that watch mode was not working because of esm, in fact, watch mode is not working if the project is in the git worktree.
If you use typescript, then typescript rebuilds the project, but the server still does not restart.

Steps to Reproduce

git clone https://github.com/railwayapp-templates/fastify --bare
cd fastify.git
git worktree add main
cd main
npm i
npm run dev

change any file -> typescript rebuild -> server does not restart

Expected Behavior

No response

Contributor guide

Research direction
Investigate the file watcher configuration in fastify cli to see why it fails to detect changes in git worktrees. Check if the watcher is using a fixed path that doesn't align with worktree's real path, or if symlinks are involved. Consider adding support for git worktree detection.
Tech stack
javascriptnodejs
Domain
clibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60