When there are multiple `AddRadioButton`s, the icons placed with `.AddCustomButton` are misaligned.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- visualbasic
- Domain
- desktop
Research direction
Reproduce the provided Sample_NoCustomIcon_multiRadioButtons case using cTaskDialog, focusing on the interaction between AddRadioButton, AddCustomButton, and ShowDialog. Compare the displayed custom-button icons with the button order and radio-button count; done means each custom button keeps its assigned icon when multiple radio buttons are present.
Written by the indexing model from the issue text.
Description
Hello. Thank you very much for the fix in issue #11.
I attempted to reopen that issue because I found an additional problem, but I received a "no permission" error. Therefore, I apologize for creating a new issue.
I have confirmed that the procedure Sample_NoCustomIcon from issue #11 works correctly. (Code omitted here.)
However, in practical use cases, it is very common to have multiple radio buttons.
For example:
Private Sub Sample_NoCustomIcon_multiRadioButtons()
Dim testIcon As LongPtr, tmp As LongPtr
Debug.Print ExtractIconExA("C:\Windows\System32\SHELL32.dll", 0, tmp, testIcon, 1)
With New cTaskDialog
.CommonButtons = TDCBF_CLOSE_BUTTON
.AddRadioButton 201, "testChose1"
.AddRadioButton 202, "testChose2"
.AddCustomButton 102, "button 2", testIcon
.AddCustomButton 101, "button 3", testIcon
.Flags = TDF_USE_COMMAND_LINKS
.ParenthWnd = Application.hWnd
.ShowDialog
End With
End Sub
When there are multiple AddRadioButton calls like this, the icon assigned in .AddCustomButton 102 is no longer displayed.
Based on my own testing, it seems that the icon assignment for .AddCustomButton is offset by the number of radio buttons added. In other words, the icon index appears to shift when radio buttons are present.
Would it be possible to ensure that the icon assignment for .AddCustomButton remains correct even when multiple .AddRadioButton calls are used?
Thank you very much for your time and support.
- Dominant language
- Visual Basic 6.0
- Stars
- 49
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fafalone/cTaskDialog64
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
fafalone/cTaskDialog64#17 · 6 comments ·
-
Not Modal Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
fafalone/cTaskDialog64#12 · 4 comments ·
All issues in fafalone/cTaskDialog64
Similar issues
-
comp/desktop P3 type/bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
NousResearch/hermes-agent#118866 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Help-Wanted Package-Request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
microsoft/winget-pkgs#438682 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·