facundoolano/google-play-scraper

Don't mutate options objects

Open

#238 opened on Jun 2, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (723 forks)github user discovery
buggood first issue

Repository metrics

Stars
 (2,948 stars)
PR merge metrics
 (Avg merge 103d 2h) (4 merged PRs in 30d)

Description

Most of the methods take an options object and then mutate by setting default values, like here. This is not a good practice, since the methods don't own those objects and are introducing unexpected side effects. Use Object.assign instead to make copies of the options.

Contributor guide

Research direction
Identify all methods in the codebase that mutate the options object parameter. For each, replace the mutation with a copy using Object.assign or spread syntax to avoid side effects.
Tech stack
javascriptnodejs
Domain
backendapi
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80