Simplify ET replay and add Integration testing

Open
#91 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Compare the replay logic in the compute and comms directories, then review the reported crash reproductions when they are added. Define the unified replay directory boundary and integration-test coverage for compute and comms; done means the replay paths are compatible and tests protect external-user behavior.

Written by the indexing model from the issue text.

Description

bug enhancement

Summary

Today there are two replay logic supported - one for only comms and one for compute+comm. This has several drawbacks

  • Code exists in two directories - compute and comms
  • Changes in one side are not testing compatibility with the other.
  • @TaekyungHeo has observed bugs and crashes with the replay when both compute and comms is enabled.

Crashes

@TaekyungHeo to add more info on how to reproduce issues

Code unification

Basic idea is to pull things out to a replay directory and unify the code
Details TBD

Integration testing

Ensure changes are unit tested to avoid impact to external users.

Dominant language
Python
Stars
156
Forks
68
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from facebookresearch/param

All issues in facebookresearch/param

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.