facebookresearch/higher

dependency installation issues with requirements.txt

Open

#87 opened on Nov 8, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,556 stars) (123 forks)batch import
help wanted

Description

I forked the project to work on it and found that merely running pip install -r requirements.txt breaks on platforms that don't match the Pytorch wheel provided in the file. The exact error is

ERROR: torch-1.2.0+cpu-cp37-cp37m-manylinux1_x86_64.whl is not a supported wheel on this platform.

I've found that changing it to torch fixes the issues.

However, the python package parameterized is missing from the list of dependencies without which test_optim.py and test_patch.py breaks.

Contributor guide

Tech stack
pythonpytorch
Domain
developer experiencebuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Locate the requirements.txt file at the root of the repository. Change the line 'torch 1.2.0+cpu cp37 cp37m manylinux1 x86 64.whl' to simply 'torch'. Additionally, add the missing dependency 'parameterized' to the requirements.txt to ensure test optim.py and test patch.py run correctly. Check if there are any existing PRs or comments addressing this change, especially from maintainers, to avoid duplication.