facebookresearch/fairseq

Missing dropout layer in LSTM model

Open

#888 opened on Jul 18, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (6,224 forks)batch import
bughelp wanted

Repository metrics

Stars
 (29,107 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/pytorch/fairseq/blob/1f5b414f0204b643244d0d8740aba32f21075395/fairseq/models/lstm.py#L496

dropout is missing from Linear function in LSTM model.

Contributor guide

Research direction
Look at the LSTM model in fairseq/models/lstm.py around line 496. The Linear function is missing a dropout parameter. Add the dropout argument to the Linear layer as per the model's configuration.
Tech stack
pythonpytorch
Domain
machine learningai
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90