facebookresearch/fairseq

Invalid suffix of raw dataset when preprocessing without language

Open

#1,426 opened on Nov 25, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (6,224 forks)batch import
bughelp wanted

Repository metrics

Stars
 (29,107 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When preprocessing using --dataset-impl raw and no source and target languages are specified, the datasets are stored under train.None-None due to this line:

https://github.com/pytorch/fairseq/blob/5349052aae4ec1350822c894fbb6be350dff61a0/preprocess.py#L218

Is this expected behavior or can we remove this suffix?

Contributor guide

Research direction
Inspect the preprocessing code at line 218 of preprocess.py to determine if the language suffix should be removed when no languages are specified. Consider whether this suffix affects dataset loading and if it's safe to remove.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75