facebookresearch/ParlAI

"maxlen" in parlai.core.torch_agent.History actually does nothing

Open

#3,013 opened on Aug 26, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (2,089 forks)batch import
Help WantedMinornever-stale

Repository metrics

Stars
 (10,371 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/facebookresearch/ParlAI/blob/c7f4b64df1a706464c053f036fe2ff38600f4558/parlai/core/torch_agent.py#L209

I think the description

  • maxlen – sets the maximum number of tunrs

should be changed to

  • size – sets the maximum number of tunrs

Contributor guide

Research direction
Locate the line in parlai/core/torch agent.py and update the docstring for maxlen to reflect that it is size, or confirm the parameter name and description.
Tech stack
python
Domain
backend
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90