facebookresearch/ParlAI

TorchAgent/TGA/TRA/... should log when initializing optimizer or not

Open

#2,953 opened on Aug 7, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (2,089 forks)batch import
Help WantedMinornever-stale

Repository metrics

Stars
 (10,371 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It's pretty useful to know whether the initializer is being created and using extra memory. We should add a log saying whether it's being hit. It might help with #2942.

Contributor guide

Research direction
Find the optimizer initialization code in TorchAgent and add a logging statement when the optimizer is created.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85