facebookresearch/ParlAI

TorchAgent/TGA/TRA/... should log when initializing optimizer or not

Open

#2,953 opened on Aug 7, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (10,371 stars) (2,089 forks)batch import
Help WantedMinornever-stale

Description

It's pretty useful to know whether the initializer is being created and using extra memory. We should add a log saying whether it's being hit. It might help with #2942.

Contributor guide

Tech stack
python
Domain
aimachine learning
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Investigate the TorchAgent class in the parlai/agents/torch agent.py file. Identify the location where the optimizer is initialized. Add a log message (e.g., using Python's logging) to indicate whether the optimizer is being created. The issue references #2942 which may provide additional context.
TorchAgent/TGA/TRA/... should log when initializing optimizer or not · facebookresearch/ParlAI#2953 | Good First Issue