facebookresearch/ParlAI

DataParallel/ModelParallel tests needed for TCA/TGA/TRA

Open

#2,508 opened on Mar 26, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Python (10,371 stars) (2,089 forks)batch import
Help WantedSmalldonotreap

Description

Bug description Though we have a few MP tests already, we have had a few bugs crop up now, indicating to me that we're not exhaustively testing.

cc @emilydinan @jxmsML

Contributor guide

Tech stack
pythonpytorch
Domain
testingmachine learning
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonParlAI basicsPyTorchsoftware testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate existing model parallel tests in the ParlAI repository, such as 'tests/test model parallel.py'. Understand the TCA, TGA, and TRA model implementations and their current test coverage. Review the issue comments and any linked PRs for context. Note that the issue has an assignee, so coordinate with them before starting work.