facebookresearch/ParlAI

Standardize batchifying image features

Open

#2,461 opened on Mar 11, 2020

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Python (2,089 forks)batch import
H2 2020Help WantedSmalldonotreap

Repository metrics

Stars
 (10,371 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently, ImageSeq2seqAgent and ImagePolyencoderAgent have two separate .batchify_image_features() methods for preparing image features for encoding. The main advantage of ImagePolyencoderAgent's implementation of this method is that the images are packed into a Tensor for data_parallel. It's worth testing whether ImageSeq2seqAgent really requires a separate .batchify_image_features() method now: if not, it should be removed, and ImagePolyencoderAgent.batchify_image_features() should be moved into TorchImageAgent.

Contributor guide

Research direction
Examine the current `batchify image features()` implementations in `ImageSeq2seqAgent` and `ImagePolyencoderAgent`. Determine if `ImageSeq2seqAgent`'s method can be replaced with `ImagePolyencoderAgent`'s version. If yes, propose moving the unified method to `TorchImageAgent` and test for correctness.
Tech stack
python
Domain
backendai
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75