facebookresearch/ParlAI

Retire custom AdamWithDecay

Open

#2,232 opened on Dec 2, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (2,089 forks)batch import
AgentsCode QualityHelp WantedMinordonotreap

Repository metrics

Stars
 (10,371 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We have a custom Adam optimizer that says it could be removed via pytorch 1.2:

https://github.com/facebookresearch/ParlAI/blob/3a5de86667816abbdb0f08049c86d1e2c3aff03e/parlai/agents/bert_ranker/helpers.py#L242-L350

The task is to remove it and upgrade to the official pytorch version.

The helper function minimizes the pain required, though I'm wondering if we'll need to upgrade some state dicts, so make sure you run long tests. https://github.com/facebookresearch/ParlAI/blob/3a5de86667816abbdb0f08049c86d1e2c3aff03e/parlai/agents/bert_ranker/helpers.py#L205

Contributor guide

Research direction
Examine the custom AdamWithDecay optimizer in helpers.py, compare it with PyTorch's Adam or AdamW, and replace the implementation. Ensure state dicts are compatible by running long tests.
Tech stack
pythonpytorch
Domain
backendmachine learning
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60