facebookresearch/ParlAI

Unify names of some options

Open

#2,170 opened on Nov 18, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (10,371 stars) (2,089 forks)batch import
Code QualityH1 2020Help WantedMinordonotreap

Description

Now that we have upgrade_opt we can do some resolution of the embedding_size and embeddingsize madness we have in seq2seq vs transformer vs memnn etc.

Contributor guide

Tech stack
pythonpytorch
Domain
developer experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonParlAI codebase familiarityunderstanding of option naming conventions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Search the codebase for all occurrences of 'embedding size' and 'embeddingsize'. These appear in seq2seq, transformer, and memnn agents. Use the existing 'upgrade opt' mechanism (likely in options.py or similar) to alias the old inconsistent names to a single unified name. Ensure that any existing configuration files still work by mapping the old names. Consult the issue comments for any additional guidance on the preferred unified name.