facebookresearch/ParlAI

Unify names of some options

Open

#2,170 opened on Nov 18, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (2,089 forks)batch import
Code QualityH1 2020Help WantedMinordonotreap

Repository metrics

Stars
 (10,371 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Now that we have upgrade_opt we can do some resolution of the embedding_size and embeddingsize madness we have in seq2seq vs transformer vs memnn etc.

Contributor guide

Research direction
Identify all occurrences of 'embedding size' and 'embeddingsize' in the codebase and unify them to a consistent name (e.g., 'embedding size'). Check seq2seq, transformer, memnn modules and any other files that use these option names.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75